Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

From: Sicilia Cristian
Date: Wed Dec 05 2018 - 16:09:59 EST


On Wed, Dec 05, 2018 at 09:46:03AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote:
> > Aligned some parameters to the previous parenthesis.
> >
> > Signed-off-by: Cristian Sicilia <sicilia.cristian@xxxxxxxxx>
> > ---
> > drivers/staging/greybus/loopback.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> > index e4d42c1..1085e06 100644
> > --- a/drivers/staging/greybus/loopback.c
> > +++ b/drivers/staging/greybus/loopback.c
> > @@ -638,7 +638,8 @@ static int gb_loopback_async_transfer(struct gb_loopback *gb, u32 len)
> > retval = gb_loopback_async_operation(gb, GB_LOOPBACK_TYPE_TRANSFER,
> > request, len + sizeof(*request),
> > len + response_len,
> > - gb_loopback_async_transfer_complete);
> > + gb_loopback_async_transfer_complete
> > + );
>
> Ick, why do this? That's not really needed.
>

Ok, better to leave it unchanged

> thanks,
>
> greg k-h

Attachment: signature.asc
Description: PGP signature