Re: [PATCH] drm/rockchip: Allow driver to be shutdown on reboot/kexec
From: Brian Norris
Date: Wed Dec 05 2018 - 13:00:55 EST
On Wed, Dec 05, 2018 at 03:11:03PM +0100, Heiko Stuebner wrote:
> Can you maybe give "drm/rockchip: shutdown drm subsystem on shutdown" [2]
> a try? When the underlying issue of rebooting surfaced we had 2 competing
> solutions, so we at least don't reopen the issue, that people have problems
> rebooting?
>
> drm-drivers seem to be short on shutdown handlers to peek at but this
> second variant mimics what tinydrm does in its shutdown
> (calling drm_atomic_helper_shutdown), so at least shouldn't be completely
> wrong.
>
>
> [2] https://patchwork.kernel.org/patch/10556151/
I tried the linked patch on Kevin and Scarlet with 4.20-rc5-ish, with
$subject reverted; I saw no warnings/complaints, and things worked OK.
Same with Kevin on 4.19.6.
I can't test on 4.4.y, since drm_atomic_helper_shutdown() doesn't exist
there.
I can provide a Tested-by to the original patch if you'd like. (I won't
provide it here, lest patchwork apply it to the $subject patch.)
Brian