Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state

[Rajendra Nayak]

On 12/5/2018 12:33 PM, Rajendra Nayak wrote:
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturnÂ0;
> > > +ÂÂÂÂÂÂÂ}
> > > +
> > > +ÂÂÂÂÂÂÂof_node_put(np);
> >
> > ThisÂsameÂcodeÂexistsÂtwice.ÂPerhapsÂaÂhelperÂneedsÂtoÂexistÂfor
> > qcom_rpm_get_performance()ÂtoÂpullÂtheÂnumberÂoutÂofÂtheÂDT.
>
> SureÂIÂcanÂmakeÂbothÂdriversÂuseÂaÂcommonÂhelperÂinsteadÂofÂduplicatingÂit.

which would mean I will need to create a new file just to define the
common helper. Does that seem like an overkill?