Re: [PATCH] x86/umip: Make the UMIP activated message generic

From: Ingo Molnar
Date: Wed Dec 05 2018 - 02:47:16 EST



* Lendacky, Thomas <Thomas.Lendacky@xxxxxxx> wrote:

> The User Mode Instruction Prevention (UMIP) feature is part of the x86_64
> instruction set architecture and not specific to Intel. Make the message
> generic.
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> ---
>
> This patch is against the x86/cpu branch of the tip tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
>
> arch/x86/kernel/cpu/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 2c56b80..cb28e98 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
>
> cr4_set_bits(X86_CR4_UMIP);
>
> - pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
> + pr_info_once("x86/cpu: User Mode Instruction Prevention (UMIP) activated\n");

Is there any public information about which AMD CPUs are going to support
it?

The latest AMD CPU I can test on is a Ryzen Threadripper 1950X, and that
doesn't have UMIP.

Thanks,

Ingo