Re: [PATCH v2 19/24] locking/lockdep: Check data structure consistency

From: Waiman Long
Date: Tue Dec 04 2018 - 15:53:47 EST


On 12/03/2018 07:28 PM, Bart Van Assche wrote:
> Debugging lockdep data structure inconsistencies is challenging. Add
> disabled code that verifies data structure consistency at runtime.
>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Waiman Long <longman@xxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> kernel/locking/lockdep.c | 147 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 147 insertions(+)

lockdep.c has close to 5000 lines of code. I wonder if we should move
most of the relocatable lockdep debugging code into a separate
lockdep_debug.c file to make it easier to manage the core lockdep code.
That, of course, will include most of the code from this patch.

Cheers,
Longman