Re: [PATCH 07/14] clock: milbeaut: Add Milbeaut M10V clock control

From: Stephen Boyd
Date: Tue Dec 04 2018 - 13:14:12 EST


Quoting Masahiro Yamada (2018-12-04 03:03:53)
> Hi Stephen,
>
>
> On Fri, Nov 30, 2018 at 5:31 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> >
> > Quoting Sugaya Taichi (2018-11-18 17:01:12)
> > > Add Milbeaut M10V clock ( including PLL ) control.
> >
> > Please give some more details here.
> >
> > >
> > > Signed-off-by: Sugaya Taichi <sugaya.taichi@xxxxxxxxxxxxx>
> > > ---
> > > drivers/clk/Makefile | 1 +
> > > drivers/clk/clk-m10v.c | 671 +++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > And this is different from Uniphier? Maybe we need a socionext
> > directory under drivers/clk/.
>
>
>
> This is always a difficult question,
> and I do not have a strong opinion.
>
>
> I am fine with moving the files to drivers/clk/socionext
> although no file would be shared.
>
>
> FYI
>
> UniPhier and Milbeaut are completely different platforms
> developed/maintained by different teams.
>
> They happen to live in the same company now
> just because Socionext merged the LSI business from Panasonic and Fujitsu.
>
> UniPhier originates in Panasonic, while Milbeaut in Fujitsu.
>

Thanks for the background info. I'd prefer to defer to however the dts
files are getting split up into directories. If they're all put under
arch/arm64/boot/dts/socionext/ then I would say combine the two clk
drivers into a socionext directory. Otherwise, keep them split out.