Re: [PATCH] platform/x86: convert to DEFINE_SHOW_ATTRIBUTE

From: Frank Lee
Date: Tue Dec 04 2018 - 10:30:34 EST


On Tue, Dec 4, 2018 at 8:40 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Dec 4, 2018 at 5:59 AM Frank Lee <tiny.windzz@xxxxxxxxx> wrote:
> >
> > On Tue, Dec 4, 2018 at 3:09 AM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > >
> > > On Sat, Dec 1, 2018 at 5:52 PM Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:
> > > >
> > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> > >
>
> I like your patch, but...
>
> > > By some reason it's not applicable.
> > > Please, rebase on top of our for-next branch, thanks!
>
> > For what reason?
>
> ...because I can't apply it, it fails with conflicts.
>
> > I thought that for-next branch has not changed much.
>
> That's correct, it's updated only by approved patch series which is
> not many _this_ cycle.
I am confused about what you said.
Because I pulled your .git down, there is no conflicts when apply it.......

MBR,
Yangtao
>
> --
> With Best Regards,
> Andy Shevchenko