Re: [PATCH v2 21/34] dt-bindings: arm: Convert Oxford Semi board/soc bindings to json-schema

From: Neil Armstrong
Date: Tue Dec 04 2018 - 03:43:14 EST


On 03/12/2018 22:32, Rob Herring wrote:
> Convert Oxford Semi SoC bindings to DT schema format using json-schema.
>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-oxnas@xxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/oxnas.txt | 14 -----------
> .../devicetree/bindings/arm/oxnas.yaml | 25 +++++++++++++++++++
> 2 files changed, 25 insertions(+), 14 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/oxnas.txt
> create mode 100644 Documentation/devicetree/bindings/arm/oxnas.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/oxnas.txt b/Documentation/devicetree/bindings/arm/oxnas.txt
> deleted file mode 100644
> index ac64e60f99f1..000000000000
> --- a/Documentation/devicetree/bindings/arm/oxnas.txt
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Oxford Semiconductor OXNAS SoCs Family device tree bindings
> --------------------------------------------
> -
> -Boards with the OX810SE SoC shall have the following properties:
> - Required root node property:
> - compatible: "oxsemi,ox810se"
> -
> -Boards with the OX820 SoC shall have the following properties:
> - Required root node property:
> - compatible: "oxsemi,ox820"
> -
> -Board compatible values:
> - - "wd,mbwe" (OX810SE)
> - - "cloudengines,pogoplugv3" (OX820)
> diff --git a/Documentation/devicetree/bindings/arm/oxnas.yaml b/Documentation/devicetree/bindings/arm/oxnas.yaml
> new file mode 100644
> index 000000000000..6ae51ef513be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/oxnas.yaml
> @@ -0,0 +1,25 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/oxnas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Oxford Semiconductor OXNAS SoCs Family device tree bindings
> +
> +maintainers:
> + - Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - wd,mbwe
> + - const: oxsemi,ox810se
> +
> + - items:
> + - enum:
> + - cloudengines,pogoplugv3
> + - const: oxsemi,ox820
>

We also loose all the "human friendly" description of board/SoC relationship here,
and I think it's a shame.

Neil