RE: [PATCH v3 0/4] Correct dma pool for imx-sdma

From: Robin Gong
Date: Tue Dec 04 2018 - 03:12:18 EST


Hello Vinod,
This patch set test by Lucas and no any other comment received yet, do you have
comments and help to push it on 4.19 stable tree?
> -----Original Message-----
> From: Robin Gong
> Sent: 2018å11æ20æ 17:09
> To: 'Lucas Stach' <l.stach@xxxxxxxxxxxxxx>; vkoul@xxxxxxxxxx
> Cc: dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: RE: [PATCH v3 0/4] Correct dma pool for imx-sdma
>
>
>
> > -----Original Message-----
> > From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Sent: 2018å11æ12æ 23:56
> > To: Robin Gong <yibin.gong@xxxxxxx>; vkoul@xxxxxxxxxx
> > Cc: dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > dl-linux-imx <linux-imx@xxxxxxx>
> > Subject: Re: [PATCH v3 0/4] Correct dma pool for imx-sdma
> >
> > Hi Robin,
> >
> > Am Dienstag, den 06.11.2018, 03:40 +0000 schrieb Robin Gong:
> > > This patch set to correct dma pool used in the commit fe5b85c656bc
> > > ("dmaengine: imx-sdma: alloclate bd memory from dma pool") because
> > > all bds should be contiguous in memory in multi bds case for sdma,
> > > but dma pool can't statify it and cause transfer failure then.Thank
> > > Lucas for the making things on the right way.
> > >
> > > This patch set is v3 based on Lucas's V1/V2, the main refine:
> > > Â --fix the issue I reported in V1 but Lucas workaround it by
> > > improper
> > > ÂÂÂÂway in V2.
> > > Â --add vchan_synchronize() to kill tasklet in virt-dma internal.
> > > Â --refine name: use sdma_disable_channel_async instead of
> > > ÂÂÂÂsdma_disable_channel_with_delay since no delay indeed for
> > > ÂÂÂÂdevice_terminate_all.
> > > Please refer to below link for more information:
> > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp
> > > at
> > >
> >
> chwork.kernel.org%2Fpatch%2F10601111&amp;data=02%7C01%7Cyibin.gong
> > %40n
> > >
> >
> xp.com%7Ce8faea984db24513bca208d648b766fc%7C686ea1d3bc2b4c6fa92cd
> > 99c5c
> > >
> >
> 301635%7C0%7C0%7C636776349873940077&amp;sdata=U6y3CMUmMfiIzBc
> > Zm7jZmXTf
> > > 4JBgOnBEiHhkY6ejzl8%3D&amp;reserved=0
> >
> > Thanks for taking care of those. I've tested them on my board and
> > things seem to work fine for all my use-cases.
> >
> > I think those patches should get a CC to stable 4.19. I guess Vinod
> > can add this when applying the patchset.
> Yes, we'd better fix on 4.19. Hope Vinod could help us.
> >
> > Regards,
> > Lucas