Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

From: Namhyung Kim
Date: Tue Dec 04 2018 - 02:47:49 EST


On Fri, Nov 30, 2018 at 10:44:06AM -0500, Steven Rostedt wrote:
> From: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
>
> This patch installs trace-seq.h header file on "make install".
>
> Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
> tools/lib/traceevent/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index adb16f845ab3..67fe5d7ef190 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -285,7 +285,7 @@ define do_install_pkgconfig_file
> fi
> endef
>
> -install_lib: all_cmd install_plugins install_pkgconfig
> +install_lib: all_cmd install_plugins install_headers install_pkgconfig
> $(call QUIET_INSTALL, $(LIB_TARGET)) \
> $(call do_install_mkdir,$(libdir_SQ)); \
> cp -fpR $(LIB_INSTALL) $(DESTDIR)$(libdir_SQ)
> @@ -302,6 +302,7 @@ install_headers:
> $(call QUIET_INSTALL, headers) \
> $(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \
> $(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \
> + $(call do_install,trace-seq.h,$(prefix)/include/traceevent,644); \
> $(call do_install,kbuffer.h,$(prefix)/include/traceevent,644)

Do you still wanna have 'traceevent' directory prefix? I just
sometimes feel a bit annoying to type it. ;-)

Or you can rename it something like 'tep' or 'libtep' - and hopefully
having only single header file to include..

Thanks,
Namhyung


>
> install: install_lib
> --
> 2.19.1
>
>