Re: [PATCH RFCv2 1/4] mm/memory_hotplug: Introduce memory block types

From: Wei Yang
Date: Mon Dec 03 2018 - 15:58:42 EST


[...]
>>>
>>> + if (type == MEMORY_BLOCK_NONE)
>>> + return -EINVAL;
>>
>> No one will pass in this value. Can we omit this check for now?
>
>I could move it to patch nr 2 I guess, but as I introduce
>MEMORY_BLOCK_NONE here it made sense to keep it in here.
>

Yes, this make sense to me now.

>(and I think at least for now it makes sense to not squash patch 1 and
>2, to easier discuss the new user interface/concept introduced in this
>patch).
>
>Thanks!
>
>--
>
>Thanks,
>
>David / dhildenb

--
Wei Yang
Help you, Help me