Re: [PATCH v3 4/8] mfd / platform: cros_ec: move debugfs attributes to its own driver.

From: Lee Jones
Date: Mon Dec 03 2018 - 05:55:29 EST


On Tue, 27 Nov 2018, Enric Balletbo i Serra wrote:

> The entire way how cros debugfs attibutes are created is broken.
> cros_ec_debugfs should be its own driver and its attributes should be
> associated with a debugfs driver not the mfd driver.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Add a "default MFD_CROS_EC_CHARDEV" in Kconfig for this.
> - Remove the checks for missing debug_info, are not needed now.
> - Remove a comment that no longer applies.
>
> drivers/platform/chrome/Kconfig | 11 ++++
> drivers/platform/chrome/Makefile | 4 +-
> drivers/platform/chrome/cros_ec_debugfs.c | 62 +++++++++++++++--------

> drivers/mfd/cros_ec_dev.c | 41 +--------------
> include/linux/mfd/cros_ec.h | 6 ---

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog