Re: [PATCH V3 1/3] mmc: sdhci: add support for using external DMA devices

From: Chunyan Zhang
Date: Mon Dec 03 2018 - 05:46:48 EST


On Mon, 3 Dec 2018 at 17:01, Faiz Abbas <faiz_abbas@xxxxxx> wrote:
>
> Hi Chunyan,
>
> On 29/11/18 2:53 PM, Adrian Hunter wrote:
> > On 29/11/18 8:07 AM, Chunyan Zhang wrote:
> >> Some standard SD host controllers can support both external dma
> >> controllers as well as ADMA/SDMA in which the SD host controller
> >> acts as DMA master. TI's omap controller is the case as an example.
> >>
> >> Currently the generic SDHCI code supports ADMA/SDMA integrated in
> >> the host controller but does not have any support for external DMA
> >> controllers implemented using dmaengine, meaning that custom code is
> >> needed for any systems that use an external DMA controller with SDHCI.
> >>
> >> Signed-off-by: Chunyan Zhang <zhang.chunyan@xxxxxxxxxx>
> >> ---
> >> drivers/mmc/host/Kconfig | 14 ++++
> >> drivers/mmc/host/sdhci.c | 185 ++++++++++++++++++++++++++++++++++++++++++++++-
> >> drivers/mmc/host/sdhci.h | 8 ++
> >> 3 files changed, 206 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >> index 1b58739..4183f43 100644
> >> --- a/drivers/mmc/host/Kconfig
> >> +++ b/drivers/mmc/host/Kconfig
> >> @@ -969,6 +969,7 @@ config MMC_SDHCI_XENON
> >> config MMC_SDHCI_OMAP
> >> tristate "TI SDHCI Controller Support">> depends on MMC_SDHCI_PLTFM && OF
> >> + select MMC_SDHCI_EXTERNAL_DMA if DMA_ENGINE
>
>
> This should be in patch 2.

Ok, will move to.

Thanks,
Chunyan

>
> Thanks,
> Faiz