Re: [PATCH 4/6] ARM: dts: sunxi: h3-h5: Add pinmux setting for CSI MCLK on PE1

[Jagan Teki]

On Fri, Nov 30, 2018 at 1:28 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> Some camera modules have the SoC feeding a master clock to the sensor
> instead of having a standalone crystal. This clock signal is generated
> from the clock control unit and output from the CSI MCLK function of
> pin PE1.
>
> Add a pinmux setting for it for camera sensors to reference.
>
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> ---

On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> The CSI controller found on the H3 (and H5) is a reduced version of the
> one found on the A31. It only has 1 channel, instead of 4 channels for
> time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> "fallback" to a compatible that implements more features than it
> supports.
>
> Drop the A31 fallback compatible.
>
> Fixes: f89120b6f554 ("ARM: dts: sun8i: Add the H3/H5 CSI controller")
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> ---

Reviewed-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>