Re: [PATCH] printk: Make printk_emit() local function.

From: Petr Mladek
Date: Thu Nov 29 2018 - 06:47:29 EST


On Sat 2018-11-24 13:10:25, Tetsuo Handa wrote:
> Well, moving "__printf(3, 4) __cold" to before
> "int devkmsg_emit(int facility, int level, const char *fmt, ...) {"
> seems to be working. I did not know...
>
> >From 86fff21e5fef6d3f7970cf5c07a54a907e582b52 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Sat, 24 Nov 2018 13:05:25 +0900
> Subject: [PATCH v2] printk: Make printk_emit() local function.
>
> printk_emit() is called from only devkmsg_write() in the same file.
> Save object size by making it a local function.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>

JFYI, I have pushed it into printk.git, for-4.21 branch.

Best Regards,
Petr