Re: [PATCH 3/3] kvm: introduce manual dirty log reprotect

[Paolo Bonzini]

On 27/11/18 06:04, Junaid Shahid wrote:
> There is a subtle point here which might be worth mentioning in a comment. [...]

You're absolutely right, it's subtle and should be mentioned.

>> @@ -2945,6 +3012,9 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
>>  	case KVM_CAP_IOEVENTFD_ANY_LENGTH:
>>  	case KVM_CAP_CHECK_EXTENSION_VM:
>>  	case KVM_CAP_ENABLE_CAP_VM:
>> +#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT
>> +	case KVM_CAP_MANUAL_DIRTY_LOG_PROTECT:
>> +#endif
> Shouldn't we also add this new CONFIG option to the Kconfig file?
> 

It's already there.  The new part is that if you are using it, you get
manual reprotection for free.

Paolo