Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Tue Nov 27 2018 - 02:57:56 EST


On Tue, Nov 27, 2018 at 07:29:07AM +0000, Yang Xiao wrote:
> From: Young_X <YangX92@xxxxxxxxxxx>

Please use your "full" name like you did in your from: line of your
email

>
> The error at line 3267 was the result of an off-by-one error in
> a for loop in line 3253.
> If condition in line 3254 never satisfies, then the value of
> pstat->aid is NUM_STA+1. This will lead to out-of-bound access
> in line 3267.

Why is this indented? No need for that.

Can you fix that up and resend?

thanks,

greg k-h