Re: [PATCH] audit/sc: remove some duplicated includes

From: Paul Moore
Date: Mon Nov 26 2018 - 18:39:17 EST


On Mon, Nov 26, 2018 at 10:05 AM Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
> kernel/auditsc.c | 2 --
> 1 file changed, 2 deletions(-)

See my previous comments.

> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index b2d1f043f17f..6b6de6e0540e 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -47,7 +47,6 @@
> #include <linux/init.h>
> #include <asm/types.h>
> #include <linux/atomic.h>
> -#include <linux/fs.h>
> #include <linux/namei.h>
> #include <linux/mm.h>
> #include <linux/export.h>
> @@ -55,7 +54,6 @@
> #include <linux/mount.h>
> #include <linux/socket.h>
> #include <linux/mqueue.h>
> -#include <linux/audit.h>
> #include <linux/personality.h>
> #include <linux/time.h>
> #include <linux/netlink.h>
> --
> 2.17.0
>


--
paul moore
www.paul-moore.com