Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

From: Masami Hiramatsu
Date: Mon Nov 26 2018 - 02:40:09 EST


On Wed, 21 Nov 2018 20:27:16 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
>
> The static inline function task_curr_ret_stack() is unused, remove it.

This looks able to be applied without this series. I think we should
apply this to for-next branch?

Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks,


>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
> include/linux/ftrace.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> index 477ff9412d26..5544df21a886 100644
> --- a/include/linux/ftrace.h
> +++ b/include/linux/ftrace.h
> @@ -819,11 +819,6 @@ extern void ftrace_graph_init_task(struct task_struct *t);
> extern void ftrace_graph_exit_task(struct task_struct *t);
> extern void ftrace_graph_init_idle_task(struct task_struct *t, int cpu);
>
> -static inline int task_curr_ret_stack(struct task_struct *t)
> -{
> - return t->curr_ret_stack;
> -}
> -
> static inline void pause_graph_tracing(void)
> {
> atomic_inc(&current->tracing_graph_pause);
> @@ -847,11 +842,6 @@ static inline int register_ftrace_graph(struct fgraph_ops *ops);
> }
> static inline void unregister_ftrace_graph(struct fgraph_ops *ops) { }
>
> -static inline int task_curr_ret_stack(struct task_struct *tsk)
> -{
> - return -1;
> -}
> -
> static inline unsigned long
> ftrace_graph_ret_addr(struct task_struct *task, int *idx, unsigned long ret,
> unsigned long *retp)
> --
> 2.19.1
>
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>