Re: [alsa-devel] [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

[Pierre-Louis Bossart]

On 11/22/18 3:56 AM, Andy Shevchenko wrote:
> On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote:
> > On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote:
> > > Compare:
> > >
> > > 	/* CFL */
> > > 	{ PCI_DEVICE(0x8086, 0xa348),
> > > 		.driver_data = (unsigned long)&snd_soc_acpi_intel_cnl_machines},
> > >
> > > to something like:
> > >
> > > #define PCI_DEVICE_ID_INTEL_AUDIO_CFL	0xa348
> > > ...
> > >
> > > 	{PCI_DEVICE_DATA(INTEL, AUDIO_CFL, &snd_soc_acpi_intel_cnl_machines)},
> > The former gives a better grep-ability, though.
> >
> > I have no big preference over two, just want to mention that both have
> > merits and demerits.
> True.
> So, up to you, guys, what to choose.

I am leaning to leave the PCI stuff alone for now. If we change the PCI 
definitions I'd like to do it on the SKL and legacy sides at the same 
time, to avoid multiple definitions or redundancies.

However I like your suggestion for the macros on the other patch so will 
change the code.

Thanks for the reviews!

>