Re: [PATCH][V2] net: hinic: fix null pointer dereference on pointer hwdev

From: David Miller
Date: Fri Nov 23 2018 - 20:22:01 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 22 Nov 2018 10:05:01 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Pointer hwdev is being dereferenced when declaring hwif , however, later
> on hwdev is being null checked, hence we have dereference before null
> check error. Fix this by assigning hwif and pdef only once hwdev has
> been null checked.
>
> Detected by CoverityScan, CID#1485581 ("Dereference before null check")
>
> Fixes: 4a61abb100c8 ("net-next/hinic:add rx checksum offload for HiNIC")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to net-next.