Re: [PATCH 11/17] soc: ti: pruss: add pruss_get()/put() API

[Tero Kristo]

On 23/11/2018 10:20, Arnd Bergmann wrote:
> On Thu, Nov 22, 2018 at 12:41 PM Roger Quadros <rogerq@xxxxxx> wrote:
>
> > +
> > +       if (IS_ERR_OR_NULL(rproc))
> > +               return ERR_PTR(-EINVAL);
>
>
> Any usage of  IS_ERR_OR_NULL() tends to be an indication of a badly
> designed API. Please change this to allow only one of the two to be passed
> around.

Should this be deprecated then?

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki