Re: [patch 17/24] x86/speculation: Move IBPB control out of switch_mm()

From: Thomas Gleixner
Date: Thu Nov 22 2018 - 17:29:44 EST


On Thu, 22 Nov 2018, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > /*
> > * Now maybe reload the debug registers and handle I/O bitmaps
> > */
> > - if (unlikely(task_thread_info(next_p)->flags & _TIF_WORK_CTXSW_NEXT ||
> > - task_thread_info(prev_p)->flags & _TIF_WORK_CTXSW_PREV))
> > + if (unlikely(next_tif & _TIF_WORK_CTXSW_NEXT ||
> > + prev_tif & _TIF_WORK_CTXSW_PREV))
> > __switch_to_xtra(prev_p, next_p, tss);
>
> Hm, the repetition between process_32.c and process_64.c is getting
> stronger - could some of this be unified into process.c? (in later
> patches)

Yes, for the price of an out of line call.

Thanks,

tglx