Re: [net] xfrm_user: use xfrm_state_put to free xfrm_state_alloc return value

From: Herbert Xu
Date: Thu Nov 22 2018 - 09:43:38 EST


On Wed, Nov 21, 2018 at 09:09:23PM +0100, Mathias Krause wrote:
>
> -- >8 --
>
> Subject: [PATCH] xfrm_user: fix freeing of xfrm states on acquire
>
> Commit 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct
> xfrm_state") moved xfrm state objects to use their own slab cache.
> However, it missed to adapt xfrm_user to use this new cache when
> freeing xfrm states.
>
> Fix this by introducing and make use of a new helper for freeing
> xfrm_state objects.
>
> Fixes: 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct xfrm_state")
> Reported-by: Pan Bian <bianpan2016@xxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.18+
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Looks good to me. Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt