Re: [PATCH] scsi/lpfc/lpfc_sli.c: Use dma_zalloc_coherent

From: John Garry
Date: Wed Nov 21 2018 - 02:56:38 EST


On 20/11/2018 21:52, James Smart wrote:
On 11/20/2018 1:40 AM, John Garry wrote:

please ensure that you maintain alignment with opening brackets

I don't think this is a requirement. From the rules I've read
preference is tabs-only indentation.

This is the only rule (enforcement) I see:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20181120&id=d1fe9c099cecc6e49324355f1b15573e9dbbe0f9

Spacing (less than a tab), after
tabs, for open brace alignment is allowed, thus is coder's choice.

It seems that alignment was being implemented with tab+space, and now it would be tab+space but no alignment.

cheers,
John


-- james