Re: çå: [PATCH 1/4] net-next/hinic:replace multiply and division operators

From: David Miller
Date: Mon Nov 19 2018 - 22:00:04 EST


From: xuechaojing <xuechaojing@xxxxxxxxxx>
Date: Tue, 20 Nov 2018 02:21:31 +0000

> This wqebb size is 32 in rx and in tx is 64, so the value is a power
> of two.

You know this.

I know this.

But developer in the future may not and try to use non-power-of-2.

Please add the necessary checks. I will not ask another time.