Re: [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend

From: David Miller
Date: Mon Nov 19 2018 - 21:43:47 EST


From: Doug Berger <opendmb@xxxxxxxxx>
Date: Mon, 19 Nov 2018 09:56:00 -0800

> It is not enough to return an error code from the driver suspend
> routine. The driver must also restore the device functionality.
>
> This commit corrects the issue introduced by commit 0db55093b566
> ("net: bcmgenet: return correct value 'ret' from bcmgenet_power_down")
> by calling the driver resume function if the suspend function returns
> an error.
>
> Changes in v2:
> - Removed accidentally included write to HFB register

Doug, this doesn't apply cleanly to net-next.