Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

From: Florian Fainelli
Date: Mon Nov 19 2018 - 13:44:43 EST


On 11/15/18 5:16 PM, Guenter Roeck wrote:
> On Thu, Nov 15, 2018 at 11:48:20AM -0800, Florian Fainelli wrote:
>>
>> OK, would you mind testing this below? It seems to me that 8250_of.c is
>> incompatible with arch/powerpc/kernel/legacy_serial.c and that is what
>> is causing the issue here.
>>
>> diff --git a/drivers/tty/serial/8250/Kconfig
>> b/drivers/tty/serial/8250/Kconfig
>> index d7737dca0e48..21cb14cbd34a 100644
>> --- a/drivers/tty/serial/8250/Kconfig
>> +++ b/drivers/tty/serial/8250/Kconfig
>> @@ -483,7 +483,7 @@ config SERIAL_8250_PXA
>>
>> config SERIAL_OF_PLATFORM
>> tristate "Devicetree based probing for 8250 ports"
>> - depends on SERIAL_8250 && OF
>> + depends on SERIAL_8250 && OF && !(PPC && PPC_UDBG_16550)
>> default SERIAL_8250
>> help
>> This option is used for all 8250 compatible serial ports that
>
> 44x/virtex5_defconfig has both PPC_UDBG_16550 and SERIAL_OF_PLATFORM enabled
> and fails to boot (or display anything on the console) with this patch applied.

Thanks for trying, can you either share or provide a link to the mpc85xx
and ml507 qemu command lines that you use? I spent a good chunk of my
time trying to get a kernel to boot but has failed so far.

Thanks
--
Florian