Re: [Patch v5 11/16] x86/speculation: Add Spectre v2 app to app protection modes

From: Jiri Kosina
Date: Mon Nov 19 2018 - 13:31:12 EST


On Mon, 19 Nov 2018, Tim Chen wrote:

> >> +DEFINE_STATIC_KEY_FALSE(spectre_v2_app_lite);
> >> +EXPORT_SYMBOL_GPL(spectre_v2_app_lite);
> >
> > Why would this be exported? The only usage site outside of this code is in
> > tlb.c which is hardly modular.
>
> That was my initial thought too. Ingo suggested to export it in
> review of v2. Wonder Ingo has some reason?
>
> https://lore.kernel.org/patchwork/patch/991759/

But why does it have to be exported at all, irrespective whether _GPL() or
not?

Thanks,

--
Jiri Kosina
SUSE Labs