RE: [PATCH 5/8] bsg: refactor bsg_ioctl

From: Avri Altman
Date: Mon Nov 19 2018 - 07:29:32 EST





> On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote:
> > Move all actual functionality into helpers, just leaving the dispatch
> > in this function.
> >
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > ---
> > block/bsg.c | 158 ++++++++++++++++++++++++----------------------------
> > 1 file changed, 72 insertions(+), 86 deletions(-)
> >
>
> Looks fine to me. Did ran the same small test-tool I ran against Jens'
> patches, nothing broke.
>
> Reviewed-by: Benjamin Block <bblock@xxxxxxxxxxxxx>
> Tested-by: Benjamin Block <bblock@xxxxxxxxxxxxx>
Tested-by: Avri Altman <avri.altman@xxxxxxx>

Tested the scsi pass-through (ufs-bsg) path - nothing is broken.