Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile

From: Leon Romanovsky
Date: Sun Nov 18 2018 - 02:13:03 EST


On Fri, Nov 16, 2018 at 03:39:47AM -0800, Mauro Carvalho Chehab wrote:
> Em Thu, 15 Nov 2018 11:43:51 -0800
> Joe Perches <joe@xxxxxxxxxxx> escreveu:
>
> > On Thu, 2018-11-15 at 19:40 +0000, Luck, Tony wrote:
> > > > I would recommend to remove this section at all.
> > > > New maintainers won't come out of blue, but will be come
> > > > from existing community and such individuals for sure will see
> > > > and judge by themselves to whom they trust and to whom not.
> > >
> > > Perhaps this is more of a hint to contributors than to maintainers
> > > (see earlier discussion on who is the target audience for these documents).
> > >
> > > It would help contributors know some names of useful reviewers (and
> > > thus this list should be picked up by scripts/get_maintainer.pl to help
> > > the user compose Cc: lists for e-mail patches).
> >
> > Trusted reviewers should be specifically listed
> > in the MAINTAINERS file with an "R:" entry.
> >
> > get_maintainers should not look anywhere else.
>
> I know that making get_maintainers to look elsewhere can make it more
> complex and slower, but IMHO, by having a per-subsystem profile, this is
> unavoidable.
>
> The thing is that touching at a single MAINTAINERS file every time a new
> reviewer comes is painful. Also, MAINTAINERS file format doesn't allow
> adding free text explaining the criteria for someone to become a
> reviewer.

You are pointing to the actual problem -> someone needs to maintain such
lists, Removal of persons from that list won't be easy task too.

>
> IMO, having reviewers on a per-subsystem file, where one could explain
> the criteria for being added there will make easier to attract more
> reviewers.
>
> Cheers,
> Mauro

Attachment: signature.asc
Description: PGP signature