Re: [PATCH net] rxrpc: Fix life check

From: David Miller
Date: Thu Nov 15 2018 - 14:36:09 EST


From: David Howells <dhowells@xxxxxxxxxx>
Date: Mon, 12 Nov 2018 22:33:22 +0000

> The life-checking function, which is used by kAFS to make sure that a call
> is still live in the event of a pending signal, only samples the received
> packet serial number counter; it doesn't actually provoke a change in the
> counter, rather relying on the server to happen to give us a packet in the
> time window.
>
> Fix this by adding a function to force a ping to be transmitted.
>
> kAFS then keeps track of whether there's been a stall, and if so, uses the
> new function to ping the server, resetting the timeout to allow the reply
> to come back.
>
> If there's a stall, a ping and the call is *still* stalled in the same
> place after another period, then the call will be aborted.
>
> Fixes: bc5e3a546d55 ("rxrpc: Use MSG_WAITALL to tell sendmsg() to temporarily ignore signals")
> Fixes: f4d15fb6f99a ("rxrpc: Provide functions for allowing cleaner handling of signals")
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied, thank you.