Re: [PATCH tip/core/rcu 6/7] mm: Replace spin_is_locked() with lockdep

From: Davidlohr Bueso
Date: Thu Nov 15 2018 - 13:49:34 EST


On Sun, 11 Nov 2018, Paul E. McKenney wrote:

From: Lance Roy <ldr709@xxxxxxxxx>

lockdep_assert_held() is better suited to checking locking requirements,
since it only checks if the current thread holds the lock regardless of
whether someone else does. This is also a step towards possibly removing
spin_is_locked().

So fyi I'm not crazy about these kind of patches simply because lockdep
is a lot less used out of anything that's not a lab, and we can be missing
potential offenders. There's obviously nothing wrong about what you describe
above perse, just my two cents.

Thansk,
Davidlohr