Re: [PATCH 1/1] net-next/hinic:fix three problems in HiNIC Driver

From: David Miller
Date: Thu Nov 15 2018 - 12:56:27 EST


From: Xue Chaojing <xuechaojing@xxxxxxxxxx>
Date: Thu, 15 Nov 2018 05:23:27 +0000

> This patch fixes these problems:
> 1. In order to improve performance, this patch add rx checksum offload
> for the HiNIC driver. Performance test(Iperf) shows more than 95%
> improvement in TCP streams.
> 2. In add_mac_addr(), if the MAC address is a muliticast address, it
> will not be set, which causes the network card fail to receive the
> multicast packet. This patch fixes this bug.
> 3. In rx_alloc_pkts(), there is a loop call of tasklet, which causes
> 100% cpu utilization, even no packets are being received. This patch
> fixes this bug.
>
> Signed-off-by: Xue Chaojing <xuechaojing@xxxxxxxxxx>

Each patch should do one thing.

Please don't combine multiple changes into one patch like this.

Post a proper patches series, one change per patch, with a proper
"[PATCH 0/N] " header posting preceeding the series.

Thanks.