Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile

[Leon Romanovsky]

On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote:
> Em Thu, 15 Nov 2018 09:03:11 +0100
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> escreveu:
>
> > Hi Dan,
> >
> > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
> > > Document the basic policies of the libnvdimm subsystem and provide a
> > > first example of a Subsystem Profile for others to duplicate and edit.
> > >
> > > Cc: Ross Zwisler <zwisler@xxxxxxxxxx>
> > > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> > > Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
> > > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- /dev/null
> > > +++ b/Documentation/nvdimm/subsystem-profile.rst
> >
> > > +Trusted Reviewers
> > > +-----------------
> > > +Johannes Thumshirn
> > > +Toshi Kani
> > > +Jeff Moyer
> > > +Robert Elliott
> >
> > Don't you want to add email addresses?
> > Only the first one is listed in MAINTAINERS.
>
> IMO, it makes sense to have their e-mails here, in a way that it could
> easily be parsed by get_maintainers.pl.

I personally think that list of "trusted reviewers" makes more harm than
good. It creates unneeded negative feelings to those who wanted to be in
this list, but for any reason they don't. Those reviewers will feel
"untrusted".

Thanks

Attachment: signature.asc
Description: PGP signature