Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

From: Finn Thain
Date: Wed Nov 14 2018 - 23:15:22 EST


On Wed, 14 Nov 2018, Russell King - ARM Linux wrote:

> However, I now see (having searched mailing lists) what you are trying
> to do - you have _not_ copied me or the mailing lists I'm on with your
> cover message, so I'm *totally* lacking in the context of your patch
> series, particularly where you are converting m68k to use clocksources
> without needing the gettimeoffset() stuff.
>

True. I should have included all interested parties in the recipients of
the cover letter. My bad.

> You have failed to explain that in this thread - probably assuming that
> I've read your cover message.

I offered to write a patch to add a clocksource to replace the
arch_gettimeoffset functionality for RPC and EBSA110.

You even replied to that offer.

I did not propose degrading functionality while there is someone able to
test modernization patches (assuming there is...).

Would you consider merging untested modernization patches for the
arch_gettimeoffset API?

> I haven't until now, because you never sent it to me or the
> linux-arm-kernel mailing list.
>
> I have found this thread _very_ frustrating, and frankly a waste of my
> time discussing the finer points because of this lack of context.

Sorry for any frustration I've caused you.

The thread went way off-topic when Christoph took the opportunity to
suggest the removal of RPC and EBSA110. That doesn't interest me.

My interest remains API modernization. The actual patches I've sent are
intended to modernize the clock API *without* degrading any functionality.

> Please ensure that if you're going to be sending a patch series, that
> the cover message at least finds its way to the intended audience of
> your patches, so that everyone has the context they need when looking at
> (eg) the single patch they may receive.
>

OK. I'll have to improve my patch submission scripts.

--

> Alternatively, if someone raises a problem with the patch, and you
> _know_ you haven't done that, then please consider informing them where
> they can get more context, eg, by providing a link to your archived
> cover message. It would help avoid misunderstandings.
>
> Thanks.
>
>