Re: [PATCH RFC v2 0/3] cleanups for pstore and ramoops

From: Kees Cook
Date: Wed Nov 14 2018 - 02:15:03 EST


On Sat, Nov 3, 2018 at 6:38 PM, Joel Fernandes (Google)
<joel@xxxxxxxxxxxxxxxxx> wrote:
> Here are some simple cleanups and fixes for ramoops in pstore. Let me know
> what you think, thanks.

I took these and slightly tweaked code locations for the first one.
I'll send out the series for review when I'm back from Plumber's.

-Kees

>
> Joel Fernandes (Google) (3):
> pstore: map pstore types to names
> pstore: simplify ramoops_get_next_prz arguments
> pstore: donot treat empty buffers as valid
>
> fs/pstore/inode.c | 53 +++++---------------------------------
> fs/pstore/ram.c | 52 +++++++++++++++----------------------
> fs/pstore/ram_core.c | 2 +-
> include/linux/pstore.h | 37 ++++++++++++++++++++++++++
> include/linux/pstore_ram.h | 2 ++
> 5 files changed, 67 insertions(+), 79 deletions(-)
>
> --
> 2.19.1.930.g4563a0d9d0-goog
>



--
Kees Cook