Re: [PATCH 04/11] ASoC: amd: add ACP3x PCM platform driver

[Mark Brown]

On Mon, Nov 12, 2018 at 11:04:55AM +0530, Vijendar Mukunda wrote:

> +static struct snd_pcm_ops acp3x_dma_ops = {
> +	.open = NULL,
> +	.close = NULL,
> +	.ioctl = NULL,
> +	.hw_params = NULL,
> +	.hw_free = NULL,
> +	.pointer = NULL,
> +	.mmap = NULL,
> +};
> +
> +struct snd_soc_dai_ops acp3x_dai_i2s_ops = {
> +	.hw_params = NULL,
> +	.trigger   = NULL,
> +	.set_fmt = NULL,
> +};

Having these empty ops sets is really surprising - I see they do get
added later on, but there's no sign that this will happen here and
assigning NULL explicitly is generally bad.  It'd be better to just
leave these empty here so they don't look like a bug when doing review.

Attachment: signature.asc
Description: PGP signature