Re: [PATCH v3 18/20] Input: hp_sdc_rtc - Switch to use %ptR

From: Dmitry Torokhov
Date: Tue Nov 13 2018 - 13:07:58 EST


On Tue, Nov 13, 2018 at 07:17:27PM +0200, Andy Shevchenko wrote:
> Use %ptR instead of open coded variant to print content of
> struct rtc_time in human readable format.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Please feel free to merge with the rest of the series.

> ---
> drivers/input/misc/hp_sdc_rtc.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
> index 47eb8ca729fe..abca895a6156 100644
> --- a/drivers/input/misc/hp_sdc_rtc.c
> +++ b/drivers/input/misc/hp_sdc_rtc.c
> @@ -441,12 +441,10 @@ static int hp_sdc_rtc_proc_show(struct seq_file *m, void *v)
> seq_puts(m, "BBRTC\t\t: READ FAILED!\n");
> } else {
> seq_printf(m,
> - "rtc_time\t: %02d:%02d:%02d\n"
> - "rtc_date\t: %04d-%02d-%02d\n"
> + "rtc_time\t: %ptRt\n"
> + "rtc_date\t: %ptRd\n"
> "rtc_epoch\t: %04lu\n",
> - tm.tm_hour, tm.tm_min, tm.tm_sec,
> - tm.tm_year + 1900, tm.tm_mon + 1,
> - tm.tm_mday, epoch);
> + &tm, &tm, epoch);
> }
>
> if (hp_sdc_rtc_read_rt(&tv)) {
> --
> 2.19.1
>

--
Dmitry