Re: [PATCH] sched/fair: make some function static

From: Peter Zijlstra
Date: Thu Nov 08 2018 - 06:06:50 EST


On Thu, Nov 08, 2018 at 01:54:12PM +0800, Yi Wang wrote:
> Make some function static as they are not used outside of fair.c.
>
> This fixes the following warning when building with 'W=1':
>
> kernel/sched/fair.c:2439:6: warning: no previous prototype for âtask_numa_workâ [-Wmissing-prototypes]
> kernel/sched/fair.c:2584:6: warning: no previous prototype for âtask_tick_numaâ [-Wmissing-prototypes]
> kernel/sched/fair.c:3548:6: warning: no previous prototype for âsync_entity_load_avgâ [-Wmissing-prototypes]
> kernel/sched/fair.c:3561:6: warning: no previous prototype for âremove_entity_load_avgâ [-Wmissing-prototypes]
>
> Signed-off-by: Yi Wang <wang.yi59@xxxxxxxxxx>

I'm not sure why; but when I apply I get:

$ quilt push
Applying patch patches/yi_wang-sched_fair-make_some_function_static.patch
patching file kernel/sched/fair.c
Hunk #1 FAILED at 2436.
Hunk #2 FAILED at 2581.
Hunk #3 FAILED at 3545.
Hunk #4 FAILED at 3558.
4 out of 4 hunks FAILED -- rejects in file kernel/sched/fair.c
Patch patches/yi_wang-sched_fair-make_some_function_static.patch does not apply (enforce with -f)D