Re: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"

From: Brian Norris
Date: Wed Nov 07 2018 - 22:16:40 EST


On Wed, Nov 7, 2018 at 1:18 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> On Wed, Nov 7, 2018 at 1:07 PM Genki Sky <sky@xxxxxxxx> wrote:
> > On Wed, 7 Nov 2018 12:55:14 -0800, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > > Ubuntu 16.04 ships with git version 2.7.4.
> >
> > Okay. I guess --no-optional-locks is a no-go then.
>
> In theory you could wrap it. If passing git with
> "--no-optional-locks" doesn't work you could fall back to the old
> code? That would mean only people with newer git would get your new
> feature and everyone else would stick with the pre-existing behavior.

+1, that's what I was going to suggest. Presumably older git would
give non-zero exit status for unknown flags, and we take that as
signal to try to the old way?