Re: [PATCH v2] ubsan: don't mark __ubsan_handle_builtin_unreachable as noreturn

From: Arnd Bergmann
Date: Wed Nov 07 2018 - 16:45:05 EST


On Wed, Nov 7, 2018 at 9:55 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 7 Nov 2018 17:45:16 +0300 Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> wrote:
>
> > From: Arnd Bergmann <arnd@xxxxxxxx>

> > --- a/lib/ubsan.c
> > +++ b/lib/ubsan.c
> > @@ -427,8 +427,7 @@ void __ubsan_handle_shift_out_of_bounds(struct shift_out_of_bounds_data *data,
> > EXPORT_SYMBOL(__ubsan_handle_shift_out_of_bounds);
> >
> >
> > -void __noreturn
> > -__ubsan_handle_builtin_unreachable(struct unreachable_data *data)
> > +void __ubsan_handle_builtin_unreachable(struct unreachable_data *data)
> > {
> > unsigned long flags;
>
> This code has been here since 2016 and presumably people will want to
> build older kernels with newer gcc's. So I'll add cc:stable, OK?
>

Yes, sounds good. Thanks,

arnd