Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

From: Matthew Wilcox
Date: Wed Nov 07 2018 - 12:37:45 EST


On Wed, Nov 07, 2018 at 05:30:22PM +0000, vitor wrote:
> Hi Matthew,
>
>
> On 07/11/18 17:05, Matthew Wilcox wrote:
> > On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote:
> > > Add driver for Synopsys DesignWare I3C master IP
> > The so-called "data sheet" (actually just an advertising brochure)
>
> The datasheet is there to download.

Really? I went to the link in your message, filled out the stupid
information box that your company has now decided to start spamming
me with, and I got a 2-page brochure telling me how wonderful it was.
It's *called* a datasheet. Even right there in its name: dwc_mipi_i3c_ds.pdf
It's not a data sheet.

> Right now the driver does not support DMA interface which will be added
> later as the other missed I3C features.
>
> What do you suggest to avoid this misunderstanding?

A big missing feature like that is probably worth mentioning in a comment.
eg: TODO: DMA support.