Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected

[Srinivas Kandagatla]

On 07/11/18 13:59, Greg KH wrote:
> Really?  I do this and then I get this build error on x86:
>
> drivers/slimbus/qcom-ngd-ctrl.c: In function âof_qcom_slim_ngd_registerâ:
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing âvoid *â pointer
>    data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
>                                                                 ^~
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member âdataâ in something not a structure or union
>
>
> So I can't take this, something else must be wrong here...
That is fine!
Yes, there seems to be one more issue here, on non DT platforms 
of_match_node is set to be NULL, which is why we are seeing this error I 
guess!

I will fix this up, do some test and send both the fixes together.

thanks,
srini