Re: [REGRESSION] OCTEON MMC driver failure with v4.19

From: Aaro Koskinen
Date: Tue Nov 06 2018 - 16:52:03 EST


Hi,

On Tue, Nov 06, 2018 at 11:05:11AM +0200, Aaro Koskinen wrote:
> On Tue, Nov 06, 2018 at 07:27:24AM +0100, Christoph Hellwig wrote:
> > On Tue, Nov 06, 2018 at 12:06:32AM +0200, Aaro Koskinen wrote:
> > > With the below change, the MMC card probe seems to with v4.19. But it
> > > feels a bit hackish, don't you think... Is there some obvious simple
> > > fix that I'm missing? Any comments?
> >
> > Please just use dma_coerce_mask_and_coherent in the platform drivers
> > instead.
>
> Tried, but that doesn't help with v4.19:
>
> [ 1.290698] octeon_mmc 1180000002000.mmc: dma_coerce_mask_and_coherent(): -5
> [ 1.297825] octeon_mmc: probe of 1180000002000.mmc failed with error -5
>
> A.

Just for the archives, the fix is: https://patchwork.kernel.org/patch/10670177/

A.