Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree

From: Alexey Dobriyan
Date: Tue Nov 06 2018 - 10:14:54 EST


On Mon, Nov 05, 2018 at 03:33:01PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> -static inline int fls(int x)
> +static inline int fls(unsigned int x)
> {
> - return fls64((unsigned int) x);
> + return fls64(x);
> }

Should it return "unsigned"? Logically it should.
I remember doing this and there was some code size increase :-(