Re: [PATCH] slab.h: Avoid using & for logical and of booleans

[Bart Van Assche]

On Mon, 2018-11-05 at 14:48 -0800, Alexander Duyck wrote:
+AD4 On Mon, Nov 5, 2018 at 2:41 PM Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 wrote:
+AD4 +AD4 How about this version, still untested? My compiler is able to evaluate
+AD4 +AD4 the switch expression if the argument is constant.
+AD4 +AD4 
+AD4 +AD4  static +AF8AXw-always+AF8-inline enum kmalloc+AF8-cache+AF8-type kmalloc+AF8-type(gfp+AF8-t flags)
+AD4 +AD4  +AHs
+AD4 +AD4 -       int is+AF8-dma +AD0 0+ADs
+AD4 +AD4 -       int type+AF8-dma +AD0 0+ADs
+AD4 +AD4 -       int is+AF8-reclaimable+ADs
+AD4 +AD4 +-       unsigned int dr +AD0 +ACEAIQ(flags +ACY +AF8AXw-GFP+AF8-RECLAIMABLE)+ADs
+AD4 +AD4 
+AD4 +AD4  +ACM-ifdef CONFIG+AF8-ZONE+AF8-DMA
+AD4 +AD4 -       is+AF8-dma +AD0 +ACEAIQ(flags +ACY +AF8AXw-GFP+AF8-DMA)+ADs
+AD4 +AD4 -       type+AF8-dma +AD0 is+AF8-dma +ACo KMALLOC+AF8-DMA+ADs
+AD4 +AD4 +-       dr +AHwAPQ +ACEAIQ(flags +ACY +AF8AXw-GFP+AF8-DMA) +ADwAPA 1+ADs
+AD4 +AD4  +ACM-endif
+AD4 +AD4 
+AD4 +AD4 -       is+AF8-reclaimable +AD0 +ACEAIQ(flags +ACY +AF8AXw-GFP+AF8-RECLAIMABLE)+ADs
+AD4 +AD4 -
+AD4 +AD4         /+ACo
+AD4 +AD4          +ACo If an allocation is both +AF8AXw-GFP+AF8-DMA and +AF8AXw-GFP+AF8-RECLAIMABLE, return
+AD4 +AD4          +ACo KMALLOC+AF8-DMA and effectively ignore +AF8AXw-GFP+AF8-RECLAIMABLE
+AD4 +AD4          +ACo-/
+AD4 +AD4 -       return type+AF8-dma +- (is+AF8-reclaimable +ACY +ACE-is+AF8-dma) +ACo KMALLOC+AF8-RECLAIM+ADs
+AD4 +AD4 +-       switch (dr) +AHs
+AD4 +AD4 +-       default:
+AD4 +AD4 +-       case 0:
+AD4 +AD4 +-               return 0+ADs
+AD4 +AD4 +-       case 1:
+AD4 +AD4 +-               return KMALLOC+AF8-RECLAIM+ADs
+AD4 +AD4 +-       case 2:
+AD4 +AD4 +-       case 3:
+AD4 +AD4 +-               return KMALLOC+AF8-DMA+ADs
+AD4 +AD4 +-       +AH0
+AD4 +AD4  +AH0
+AD4
+AD4 Doesn't this defeat the whole point of the code which I thought was to
+AD4 avoid conditional jumps and branches? Also why would you bother with
+AD4 the +ACI-dr+ACI value when you could just mask the flags value and switch on
+AD4 that directly?

Storing the relevant bits of 'flags' in the 'dr' variable avoids that the
bit selection expressions have to be repeated and allows to use a switch
statement instead of multiple if / else statements.

Most kmalloc() calls pass a constant to the gfp argument. That allows the
compiler to evaluate kmalloc+AF8-type() at compile time. So the conditional jumps
and branches only appear when the gfp argument is not a constant. What makes
you think it is important to optimize for that case?

Bart.