Re: [PATCH v15 23/23] x86/sgx: Driver documentation

From: Dave Hansen
Date: Mon Nov 05 2018 - 15:27:14 EST


On 11/2/18 4:11 PM, Jarkko Sakkinen wrote:
> Documentation/index.rst | 1 +
> Documentation/x86/intel_sgx.rst | 185 ++++++++++++++++++++++++++++++++
> 2 files changed, 186 insertions(+)
> create mode 100644 Documentation/x86/intel_sgx.rst

This patch set establishes an ABI. It basically sets in stone a bunch
of behaviors that the enclave, the kernel, and the out-of-enclave code
must follow.

There are a bunch of things that the enclave can do to %rsp or %rip, for
instance, that it is capable and/or permitted to do.

The ABI seems entirely undocumented and rather lightly designed, which
seems like something we should fix before this is merged.

Also, for a feature as massive and complicated as this one, it seems
irresponsible to not have a selftest. Is that not feasible for some reason?