Re: [PATCH 09/11] [media] marvell-ccic/mmp: add devicetree support

[Pavel Machek]

On Mon 2018-11-05 08:30:52, Lubomir Rintel wrote:
> The platform data is actually not used anywhere (along with the CSI
> support) and should be safe to remove.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>


> +	} else {
> +		/*
> +		 * This are values that used to be hardcoded in mcam-core and

"These are values"? "and it"?

> +		 * work well on a OLPC XO 1.75 with a parallel bus sensor.
> +		 * If it turns out other setups make sense, the values should
> +		 * be obtained from the device tree.
> +		 */
> +		mcam->mclk_src = 3;
> +		mcam->mclk_div = 2;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature