Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

From: Shawn Guo
Date: Sat Nov 03 2018 - 23:55:20 EST


On Wed, Oct 31, 2018 at 12:17:50PM +0000, Leonard Crestez wrote:
> On 10/31/2018 8:12 AM, Shawn Guo wrote:
> > On Mon, Oct 08, 2018 at 06:06:23PM +0000, Leonard Crestez wrote:
> >> This was implemented in the driver but not actually defined and
> >> referenced in dts. This makes it always on.
> >>
> >> From reference manual in section "10.4.1.4.1 Power Distribution":
> >>
> >> "Display domain - The DISPLAY domain contains GIS, CSI, PXP, LCDIF,
> >> PCIe, DCIC, and LDB. It is supplied by internal regulator."
> >>
> >> The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is
> >> actually inside the DISPLAY domain. Handle this by adding the pcie node
> >> in both power domains.
> >>
> >> Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> >
> > Applied, thanks.
>
> As mentioned in the cover letter this requires multi-PD support in
> imx-pci to be implemented, specifically PATCH 3/4 of this series:
>
> https://lore.kernel.org/patchwork/patch/996810/
>
> Unless that also gets merged soon via pci I expect issues in linux-next.
> The patch already has reviewed-by tags so "merging it soon" is not
> unreasonable.

Oops, I overlooked the notes in cover-letter. Let's use the approach as
suggested there - applying the dts change after all driver dependencies
are landed.

Patch dropped, sorry.